On 07/24/2017 01:27 PM, Philippe Mathieu-Daudé wrote: > If find_bitmap_by_name() fails we have bm=NULL and go to the 'fail' label, > then > call bitmap_free(bm) which does g_free(bm->name) with bm=NULL... > > Clang's scan-build-5.0 output: > block/qcow2-bitmap.c:492:12: warning: Access to field 'name' results in a > dereference of a null pointer (loaded from variable 'bm') > g_free(bm->name); > ^~~~~~~~ > > Reported-by: Clang Static Analyzer > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > block/qcow2-bitmap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)
Max already has a better patch from Vladimir pending on his block queue: https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg04398.html -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
