David Hildenbrand recently posted a series of patches correcting various mistakes in the computation of ILEN for various instructions in the respective helpers.
I think a better approach is to include ilen in the set of unwind data for each insn. In this way we can fix these sorts of errors automatically. At the same time begin to wean ourselves away from ILEN_AUTO, which requires re-reading from the instruction stream. Almost certainly 2.11 material. Thoughts? r~ Richard Henderson (4): target/s390x: Add ilen to unwind data target/s390x: Use ILEN_UNWIND in trivial cases target/s390x: Use unwind info in STSI target/s390x: Use ilen from unwind in tlb_fill target/s390x/cpu.h | 9 ++++++--- target/s390x/helper.c | 14 ++++++++------ target/s390x/mem_helper.c | 39 +++++++++++++++++++++++++-------------- target/s390x/misc_helper.c | 10 +++++++--- target/s390x/translate.c | 10 ++++++++-- 5 files changed, 54 insertions(+), 28 deletions(-) -- 2.13.3
