On 07/25/2017 10:56 AM, Max Reitz wrote: > On one hand, the _make_test_img invocation for creating the target image > was missing a -u because its backing file is not supposed to exist at > that point. > > On the other hand, nobody noticed probably because the backing file is > created later on and _cleanup failed to remove it: The quotation marks > were misplaced so bash tried to deleted a file literally called
s/deleted/delete/
> "$TEST_IMG{,.target}..." instead of resolving the globs. Thus, the
Technically brace expansion, not globs.
> files stayed around after the first run and qemu-img create did not
> complain about a missing backing file on any run but the first.
>
> Signed-off-by: Max Reitz <mre...@redhat.com>
> ---
> tests/qemu-iotests/156 | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
