On Wed, Jul 26, 2017 at 01:32:41PM +1000, Alexey Kardashevskiy wrote: > On 26/07/17 03:58, Greg Kurz wrote: > > This function is only used when creating the default PHB. Let's rename > > it and move it to the core machine code for clarity. > > > > Signed-off-by: Greg Kurz <gr...@kaod.org> > > --- > > hw/ppc/spapr.c | 13 ++++++++++++- > > hw/ppc/spapr_pci.c | 11 ----------- > > include/hw/pci-host/spapr.h | 2 -- > > 3 files changed, 12 insertions(+), 14 deletions(-) > > > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > > index 2a3e53d5d58c..53969315ac24 100644 > > --- a/hw/ppc/spapr.c > > +++ b/hw/ppc/spapr.c > > @@ -2142,6 +2142,17 @@ static void spapr_init_cpus(sPAPRMachineState *spapr) > > g_free(type); > > } > > > > +static PCIHostState *spapr_create_default_phb(sPAPRMachineState *spapr) > > > Nit: you could get rid of the *spapr here. > > Anyway, > > Reviewed-by: Alexey Kardashevskiy <a...@ozlabs.ru>
Reviewed-by: David Gibson <da...@gibson.dropbear.id.au>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
