On 11/16/10 02:16, Michael Roth wrote:
> + if (pkt->type == VP_PKT_CLIENT) {
> + TRACE("recieved client packet, client fd: %d, server fd: %d",
> + pkt->payload.proxied.client_fd,
> pkt->payload.proxied.server_fd);
> + fd = pkt->payload.proxied.server_fd;
> + } else if (pkt->type == VP_PKT_SERVER) {
> + TRACE("recieved server packet, client fd: %d, server fd: %d",
> + pkt->payload.proxied.client_fd,
> pkt->payload.proxied.server_fd);
> + fd = pkt->payload.proxied.client_fd;
> + } else {
> + TRACE("unknown packet type");
> + return -1;
> + }
-1 isn't a very friendly error value to pass up the stack.
> + /* TODO: proxied in non-blocking mode can causes us to spin here
> + * for slow servers/clients. need to use write()'s and maintain
> + * a per-conn write queue that we clear out before sending any
> + * more data to the fd
> + */
> + ret = vp_send_all(fd, (void *)pkt->payload.proxied.data,
> + pkt->payload.proxied.bytes);
> + if (ret == -1) {
> + LOG("error sending data over channel");
> + return -1;
> + } else if (ret != pkt->payload.proxied.bytes) {
> + TRACE("buffer full?");
> + return -1;
> + }
Again here, please pass the error codes up the stack so we can later
handle them appropriately.
Cheers,
Jes
