On 26.07.2017 16:38, Paolo Bonzini wrote: > On 26/07/2017 16:17, Thomas Huth wrote: >> On 26.07.2017 16:02, Daniel P. Berrange wrote: >>> On Wed, Jul 26, 2017 at 03:27:30PM +0200, Thomas Huth wrote: >>>> Most browsers try to download a /favicon.ico file from the web servers >>>> which is then e.g. used in the browser tabs or bookmark lists. So let's >>>> add such a file for the QEMU website, too. The .ico has been created >>>> resizing the logo from http://wiki.qemu.org/Logo to 16x16 pixels. >>>> >>>> Signed-off-by: Thomas Huth <th...@redhat.com> >>> >>> FYI, just having a single 'favicon.ico' file isn't generally sufficient >>> anymore. Thanks to explosion of mobile devices there are 20+ different files >>> that various browsers / clients look for now :-( >> >> Well, yeah, but most of that is just sick. Adding things like '<link >> rel="apple-touch-icon" .../>' to your web site is IMHO just how it >> should *not* be done. >> If we're afraid that the 16x16 pixel icon is not enough, I think we >> should add an additional SVG icon, smile at the browsers that support it >> and wait for the others to catch up. > > It has the advantage of working: > > ----------------- 8< ----------- > From ba78908efd551c514a5156a3882316df76bee2e4 Mon Sep 17 00:00:00 2001 > From: Thomas Huth <th...@redhat.com> > Date: Wed, 26 Jul 2017 15:27:30 +0200 > Subject: [qemu-web PATCH 1/1] Add a favicon file > > Most browsers try to download a /favicon.ico file or similar from the > web servers which is then e.g. used in the browser tabs or bookmark > lists. So let's add such a file for the QEMU website, too. > > The files and HTML were created with realfavicongenerator.net. > > Signed-off-by: Thomas Huth <th...@redhat.com> > Message-Id: <1501075650-6971-1-git-send-email-th...@redhat.com> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > _includes/assets.html | 9 +++ > assets/favicons/android-chrome-192x192.png | Bin 0 -> 23519 bytes > assets/favicons/android-chrome-512x512.png | Bin 0 -> 69749 bytes > assets/favicons/apple-touch-icon.png | Bin 0 -> 15455 bytes > assets/favicons/browserconfig.xml | 9 +++ > assets/favicons/favicon-16x16.png | Bin 0 -> 1356 bytes > assets/favicons/favicon-32x32.png | Bin 0 -> 2363 bytes > assets/favicons/manifest.json | 18 +++++ > assets/favicons/mstile-150x150.png | Bin 0 -> 13296 bytes > assets/favicons/safari-pinned-tab.svg | 124 > +++++++++++++++++++++++++++++ > favicon.ico | Bin 0 -> 15086 bytes > 11 files changed, 160 insertions(+) > create mode 100644 assets/favicons/android-chrome-192x192.png > create mode 100644 assets/favicons/android-chrome-512x512.png > create mode 100644 assets/favicons/apple-touch-icon.png > create mode 100644 assets/favicons/browserconfig.xml > create mode 100644 assets/favicons/favicon-16x16.png > create mode 100644 assets/favicons/favicon-32x32.png > create mode 100644 assets/favicons/manifest.json > create mode 100644 assets/favicons/mstile-150x150.png > create mode 100644 assets/favicons/safari-pinned-tab.svg > create mode 100644 favicon.ico
If you're willing to maintain that "mess", sure, please go ahead! But please remove my SoB, I don't want to be responsible for all those files ;-) Thomas
