On Thu, 27 Jul 2017 03:54:16 +0200
Dong Jia Shi <bjsdj...@linux.vnet.ibm.com> wrote:
> Let's use a macro for the ERC (error recover code) when generating a
> Channel Subsystem Event-information pending CRW (channel report word).
Sounds reasonable.
>
> Signed-off-by: Dong Jia Shi <bjsdj...@linux.vnet.ibm.com>
> ---
> hw/s390x/css.c | 2 +-
> include/hw/s390x/ioinst.h | 5 +++--
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/hw/s390x/css.c b/hw/s390x/css.c
> index 6a42b95cee..5321ca016b 100644
> --- a/hw/s390x/css.c
> +++ b/hw/s390x/css.c
> @@ -2103,7 +2103,7 @@ void css_generate_chp_crws(uint8_t cssid, uint8_t chpid)
> void css_generate_css_crws(uint8_t cssid)
> {
> if (!channel_subsys.sei_pending) {
> - css_queue_crw(CRW_RSC_CSS, 0, 0, cssid);
> + css_queue_crw(CRW_RSC_CSS, CRW_ERC_EVENT, 0, cssid);
> }
> channel_subsys.sei_pending = true;
> }
> diff --git a/include/hw/s390x/ioinst.h b/include/hw/s390x/ioinst.h
> index 92d15655e4..c1d1052279 100644
> --- a/include/hw/s390x/ioinst.h
> +++ b/include/hw/s390x/ioinst.h
> @@ -201,8 +201,9 @@ typedef struct CRW {
> #define CRW_FLAGS_MASK_A 0x0080
> #define CRW_FLAGS_MASK_ERC 0x003f
>
> -#define CRW_ERC_INIT 0x02
> -#define CRW_ERC_IPI 0x04
> +#define CRW_ERC_EVENT 0x00
OK, that matches the name the Linux kernel uses.
Do we want to add all ERCs while we're at it?
> +#define CRW_ERC_INIT 0x02
> +#define CRW_ERC_IPI 0x04
>
> #define CRW_RSC_SUBCH 0x3
> #define CRW_RSC_CHP 0x4
