On 07/28/2017 08:45 AM, Markus Armbruster wrote: > BlockDeviceMapEntry has never been used. It was added in commit > facd6e2 "so that it is published through the introspection mechanism." > What exactly introspecting types that aren't used for anything could > accomplish isn't clear. What "introspection mechanism" to use is also > nebulous. To the best of my knowledge, there has never been one that > covered this type. Certainly not query-qmp-schema, which includes > only types that are actually used in QMP. > > Not being able to introspect BlockDeviceMapEntry hasn't bothered > anyone enough to complain in almost four years. Get rid of it.
This type is the schema for 'qemu-img map --output=json'. And I had a patch once (that I need to revive) that added a JSON Output visitor; at which point I fixed qemu-img to convert from QAPI to JSON instead of open-coding its construction of its output string, at which point the QAPI generated code for this type is useful. But that's a revert away for when I rebase my series to actually use it; and in the meantime, pruning unused types isn't hurting anything. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
