On 07/28/2017 07:10 AM, Vadim Galitsyn wrote: > This command is an equivalent of QMP command query-memory-size-summary. > It provides the following memory information in bytes: > > * base-memory - size of "base" memory specified with command line option -m. > > * hotunpluggable-memory - amount of memory that was hot-plugged. > If target does not have CONFIG_MEM_HOTPLUG enabled, no > value is reported.
Most of our HMP commands use underscores between words; for consistency, you might want to name it 'info memory_size_summary'. Also, between the new QMP and HMP parameters, do you have any testsuite coverage? I know we don't have many existing QMP tests to copy from, but where possible, we want to avoid adding new QMP features that don't have some sort of coverage. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
