On Thu, Aug 03, 2017 at 12:21:41PM +0100, Dr. David Alan Gilbert wrote:
[...]
> > +static int migrate_handle_rp_resume_ack(MigrationState *s, uint32_t value)
> > +{
> > + trace_source_return_path_thread_resume_ack(value);
> > +
> > + /*
> > + * Currently value will always be one. It can be used in the
> > + * future to notify source that destination cannot continue.
> > + */
> > + assert(value == 1);
>
> Again I prefer the routine to fail than to assert.
> Maybe it's worth having a constant rather than the magic 1.
Will do. Thanks,
--
Peter Xu
