On 08/08/2017 03:20 PM, Eric Blake wrote: > On 08/08/2017 12:57 PM, John Snow wrote: >> From: Kevin Wolf <kw...@redhat.com> >> >> Signed-off-by: Kevin Wolf <kw...@redhat.com> >> Signed-off-by: John Snow <js...@redhat.com> >> --- >> tests/ide-test.c | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> > >> +static void test_flush_empty_drive(void) >> +{ >> + QPCIDevice *dev; >> + QPCIBar bmdma_bar, ide_bar; >> + >> + ide_test_start("-device ide-cd,bus=ide.0"); >> + dev = get_pci_device(&bmdma_bar, &ide_bar); >> + >> + /* FLUSH CACHE command on device 0*/ > > Space before */ > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > I agree with your assessment of 1 and 2 being 2.10 material. >
Yep, thanks. I just wanted to include Kevin's attempt at fixing the root problem to make it clear that: (A) The root problem is known and being worked on, but (B) Is evidently not ready for prime time. I'll stage 1 & 2 with your minor typo edit here, thank you. --js