Hi, This series seems to have some coding style problems. See output below for more information:
Message-id: 20170808183306.27474-1-js...@redhat.com Subject: [Qemu-devel] [PATCH 0/9] IDE: replace printfs with tracing Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 56439344ef AHCI: remove DPRINTF macro 6ad85afba9 AHCI: pretty-print FIS to buffer instead of stderr dfcd58be6d AHCI: Rework IRQ constants 77feb08d1d AHCI: Replace DPRINTF with trace-events 5657a4914e IDE: replace DEBUG_AIO with trace events 7708ba0158 ATAPI: Replace DEBUG_IDE_ATAPI with tracing events c007da81b2 IDE: add tracing for data ports 07cc43a5ff IDE: Add register hints to tracing a5a7b507be IDE: replace DEBUG_IDE with tracing system === OUTPUT BEGIN === Checking PATCH 1/9: IDE: replace DEBUG_IDE with tracing system... ERROR: spaces required around that '|' (ctx:VxV) #139: FILE: hw/ide/core.c:1189: + if (reg_num != 7 && (s->status & (BUSY_STAT|DRQ_STAT))) { ^ ERROR: space required before the open parenthesis '(' #144: FILE: hw/ide/core.c:1193: + switch(reg_num) { ERROR: space required before the open parenthesis '(' #191: FILE: hw/ide/core.c:2058: + switch(reg_num) { total: 3 errors, 0 warnings, 335 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 2/9: IDE: Add register hints to tracing... Checking PATCH 3/9: IDE: add tracing for data ports... Checking PATCH 4/9: ATAPI: Replace DEBUG_IDE_ATAPI with tracing events... Checking PATCH 5/9: IDE: replace DEBUG_AIO with trace events... Checking PATCH 6/9: AHCI: Replace DPRINTF with trace-events... ERROR: Hex numbers must be prefixed with '0x' #543: FILE: hw/ide/trace-events:88: +handle_reg_h2d_fis_pmp(void *s, int port, char b0, char b1, char b2) "ahci(%p)[%d]: Port Multiplier not supported, FIS: 0x%02x-%02x-%02x" ERROR: Hex numbers must be prefixed with '0x' #544: FILE: hw/ide/trace-events:89: +handle_reg_h2d_fis_res(void *s, int port, char b0, char b1, char b2) "ahci(%p)[%d]: Reserved flags set in H2D Register FIS, FIS: 0x%02x-%02x-%02x" ERROR: Hex numbers must be prefixed with '0x' #550: FILE: hw/ide/trace-events:95: +handle_cmd_unhandled_fis(void *s, int port, uint8_t b0, uint8_t b1, uint8_t b2) "ahci(%p)[%d]: unhandled FIS type. cmd_fis: 0x%02x-%02x-%02x" total: 3 errors, 0 warnings, 500 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 7/9: AHCI: Rework IRQ constants... Checking PATCH 8/9: AHCI: pretty-print FIS to buffer instead of stderr... ERROR: Use g_assert or g_assert_not_reached #35: FILE: hw/ide/ahci.c:658: + g_assert_cmpint(cmd_len, <=, 0x100); total: 1 errors, 0 warnings, 85 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 9/9: AHCI: remove DPRINTF macro... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org