Markus Armbruster <arm...@redhat.com> writes: [...] > Out of review brainpower for today. Hope to resume tomorrow. > > [...]
Nope, I'm giving up on this one. Please split it for reviewability. Suggested split: 1. Preparatory refactoring for step 2, step by step 2. Frontend part: accept and check 'if', step by step The accepted conditions should be visible in tests/qapi-schema/qapi-schema-test.out. 3. Preparatory refactoring for step 4, step by step 4. Backend part: generate the ifdeffery, step by step You already split off qapi2texi steps [PATCH 12-15]. Good. Perhaps that's all that can be split off, perhaps not. PATCH 08-11 may well profit from the same treatment. Moving on to PATCH 16.
