On Fri, 18 Aug 2017 12:04:14 +0200 Thomas Huth <th...@redhat.com> wrote:
> On 18.08.2017 11:59, David Hildenbrand wrote: > > On 17.08.2017 11:22, David Hildenbrand wrote: > >> While at it, move the translations into the function. > >> > >> Signed-off-by: David Hildenbrand <da...@redhat.com> > >> --- > >> target/s390x/cc_helper.c | 48 > >> ++++++++++++++++++++++++++++++++++++++++++++++++ > >> target/s390x/cpu.h | 48 > >> +----------------------------------------------- > >> 2 files changed, 49 insertions(+), 47 deletions(-) > [...] > > Just compiled with --disable-tcg > > > > s390_cpu_dump_state() needs cc_name. I suggest moving it to helper.c > > instead. Opinions? > > Sounds fine to me, too. > > Thomas > > Agreed.