On Fri, Aug 18, 2017 at 09:28:55PM +0300, Michael S. Tsirkin wrote: > On Wed, Aug 16, 2017 at 09:26:51AM +0800, Dou Liyang wrote: > > Currently, Using the fisrt node without memory on the machine makes > > QEMU unhappy. With this example command line: > > ... \ > > -m 1024M,slots=4,maxmem=32G \ > > -numa node,nodeid=0 \ > > -numa node,mem=1024M,nodeid=1 \ > > -numa node,nodeid=2 \ > > -numa node,nodeid=3 \ > > Guest reports "No NUMA configuration found" and the NUMA topology is > > wrong. > > > > This is because when QEMU builds ACPI SRAT, it regards node0 as the > > default node to deal with the memory hole(640K-1M). this means the > > node0 must have some memory(>1M), but, actually it can have no > > memory. > > > > Fix this problem by replace the node0 with the first node which has > > memory on it. Add a new function for each node. Also do some cleanup. > > > > Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> > > This isn't a regression, is it? > If so I think it's safe to postpone this to 2.11.
Agreed. I was already treating it as a candidate for 2.11 only. -- Eduardo
