On 07/31/2017 05:51 AM, Amador Pahim wrote:
For increased portability, let's use os.path.devnull.

Signed-off-by: Amador Pahim <apa...@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>

---
  scripts/qemu.py | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/qemu.py b/scripts/qemu.py
index 9434ccc30b..d313c6d4db 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -80,7 +80,7 @@ class QEMUMachine(object):
          fd_param = ["%s" % self._socket_scm_helper,
                      "%d" % self._qmp.get_sock_fd(),
                      "%s" % fd_file_path]
-        devnull = open('/dev/null', 'rb')
+        devnull = open(os.path.devnull, 'rb')
          p = subprocess.Popen(fd_param, stdin=devnull, stdout=sys.stdout,
                               stderr=sys.stderr)
          return p.wait()
@@ -137,7 +137,7 @@ class QEMUMachine(object):
def launch(self):
          '''Launch the VM and establish a QMP connection'''
-        devnull = open('/dev/null', 'rb')
+        devnull = open(os.path.devnull, 'rb')
          qemulog = open(self._qemu_log_path, 'wb')
          try:
              self._pre_launch()


Reply via email to