On 08/22/2017 10:09 AM, Markus Armbruster wrote: > #define qdict_put_bool(qdict, key, value) \ >> qdict_put(qdict, key, qbool_from_bool(value)) >> #define qdict_put_str(qdict, key, value) \ >> qdict_put(qdict, key, qstring_from_str(value)) >> +#define qdict_put_null(qdict, key) \ >> + qdict_put(qdict, key, qnull()) >> >> /* High level helpers */ >> double qdict_get_double(const QDict *qdict, const char *key); > > Marginal. I can accept it for completeness's sake, or rather a step > towards completeness. But please update the "Helpers for ..." comment, > and convert existing qdict_put(QD, K, qnull()) to use qdict_put_null(). > A quick grep finds some in target/i386/cpu.c. There might be more.
And we already used Coccinelle to find candidates for qdict_put_bool and friends, so that should be the reasonable approach to use here as well. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
