On Mon, Aug 21, 2017 at 03:49:05PM +0200, Gerd Hoffmann wrote: > On Thu, 2017-08-10 at 16:55 +0100, Daniel P. Berrange wrote: > > - virtio_input_key_config(vinput, keymap_qcode, > > - ARRAY_SIZE(keymap_qcode)); > > + virtio_input_key_config(vinput, qemu_input_map_qcode2linux, > > + qemu_input_map_qcode2linux_len); > > That is a guest-visible change.
Huh, really ?!?!? Are you saying the guest OS sees the raw qcode values ? IIUC these are something we never wanted to expose outside QEMU, because nothing in QAPI is gauranteeing enum values are stable - only the string representation is stable in QAPI. I thought this device was sending linux keycodes to the guest, not qcodes ???? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|