On Wed, Aug 30, 2017 at 03:26:58AM -0500, Sergio Andres Gomez Del Real wrote:
> @@ -613,6 +614,15 @@ static uint32_t xsave_area_size(uint64_t mask)
> return ret;
> }
>
> +static inline bool accel_uses_host_cpuid(void)
> +{
> + if (kvm_enabled() || hvf_enabled()) {
> + return true;
> + } else {
> + return false;
> + }
Shorter equivalent:
return kvm_enabled() || hvf_enabled();
> @@ -2396,6 +2427,7 @@ static void x86_cpu_load_def(X86CPU *cpu,
> X86CPUDefinition *def, Error **errp)
> }
>
> /* Special cases not set in the X86CPUDefinition structs: */
> + /* TODO: implement for hvf */
This patch has several todos. What is missing? What is the impact of
silently skipping this for hvf?
