On 08/31/2017 07:28 AM, Peter Maydell wrote:
On 31 August 2017 at 04:53, Philippe Mathieu-Daudé <f4...@amsat.org> wrote:
Suggested-by: Peter Maydell <peter.mayd...@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
---
  include/hw/char/serial.h |  1 +
  hw/char/serial.c         | 13 +++++++++++++
  2 files changed, 14 insertions(+)

diff --git a/include/hw/char/serial.h b/include/hw/char/serial.h
index c4daf11a14..96bccb39e1 100644
--- a/include/hw/char/serial.h
+++ b/include/hw/char/serial.h
@@ -93,6 +93,7 @@ SerialState *serial_mm_init(MemoryRegion *address_space,
                              hwaddr base, int it_shift,
                              qemu_irq irq, int baudbase,
                              Chardev *chr, enum device_endian end);
+Chardev *serial_chr_nonnull(Chardev *chr);

For new globally-visible function declarations, can we
have a doc-comment form comment that documents the
function, please?

I was afraid someone asked that, but since this file has no other comment I tried :p

Good to know for future contributions, someone fluent with English should add this to CODING_STYLE.

Reply via email to