On Fri, Sep 01, 2017 at 10:25:42AM -0600, Jan Beulich wrote: > Xen and qemu having identical #define-s (with different names) is a > strong hint that these should have been part of the public interface > from the very start. Use them if they're available, falling back to > privately defined values only when using older headers. > > Signed-off-by: Jan Beulich <jbeul...@suse.com>
Reviewed-by: Roger Pau Monné <roger....@citrix.com> > > --- a/hw/xen/xen_pt_msi.c > +++ b/hw/xen/xen_pt_msi.c > @@ -18,6 +18,11 @@ > > #define XEN_PT_AUTO_ASSIGN -1 > > +#ifndef XEN_DOMCTL_VMSI_X86_DEST_ID_MASK > +#if XEN_DOMCTL_INTERFACE_VERSION >= 0x0000000e XEN_DOMCTL_INTERFACE_VERSION is already 0xe (without you added defines), I guess it doesn't matter much because we only care for stable releases. I would probably be fine without the interface check and the error, but I don't know the approach we usually take regarding those. Thanks, Roger.
