On 01.09.2017 20:03, Eric Blake wrote: > As a general rule, we prefer avoiding implicit global state > because it makes code harder to safely copy and paste without > thinking about the global state. Although qmp-test does not > maintain parallel qtest connections, it was the last test > assigning to global_qtest. It's just as easy to be explicit > about the state; once all tests have been cleaned up, a later > patch can then get rid of global_qtest and a layer of wrappers > in libqtest. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > --- > tests/qmp-test.c | 35 ++++++++++++++++++----------------- > 1 file changed, 18 insertions(+), 17 deletions(-)
Reviewed-by: Thomas Huth <th...@redhat.com>