On 01.09.2017 20:03, Eric Blake wrote:
> As a general rule, we prefer avoiding implicit global state
> because it makes code harder to safely copy and paste without
> thinking about the global state. Although bios-tables-test does
> not maintain parallel qtest connections, it's just as easy to be
> explicit about the state; once all tests have been cleaned up, a
> later patch can then get rid of global_qtest and a layer of
> wrappers in libqtest.
>
> Signed-off-by: Eric Blake <ebl...@redhat.com>
> ---
> tests/bios-tables-test.c | 78
> +++++++++++++++++++++++++-----------------------
> 1 file changed, 40 insertions(+), 38 deletions(-)
>
> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
> index 75b29df493..976792f2c5 100644
> --- a/tests/bios-tables-test.c
> +++ b/tests/bios-tables-test.c
> @@ -38,6 +38,7 @@ typedef struct {
> struct smbios_21_entry_point smbios_ep_table;
> uint8_t *required_struct_types;
> int required_struct_types_len;
> + QTestState *qts;
> } test_data;
Ah, well, ok, here it is. Please merge this with the previous patch!
Thomas
