On 08/21/2017 05:08 AM, Peter Maydell wrote: > On 21 August 2017 at 10:31, Markus Armbruster <arm...@redhat.com> wrote: >> I'm fine with project-wide, but does it have to be a hard error? Can we >> make it a warning? Same effect by default, but it lets people >> experiment more easily with --disable-werror. > > It won't be the same effect by default for our releases, which > don't use -Werror. > > I don't think we want to make it easy for people to turn this > off -- and it's only commenting out a single #error line if > anybody really does want to mess about with it.
Two lines, actually, since we are also prohibiting disabling g_assert(). Anyways, as the topic came up again on the list, should I promote this patch from RFC to actual patch? Whose tree would it go in through? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature