On 09/06/2017 11:16 AM, Matthew Rosato wrote: > On 09/04/2017 11:43 AM, David Hildenbrand wrote: >> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the >> guest tries to bring these CPUs up but fails), because we don't support >> multiple CPUs on s390x under TCG. >> >> Let's bail out if more than 1 is specified, so we don't raise people's >> hope. Make it a define, so we can easily bump it up later. >> >> Signed-off-by: David Hildenbrand <da...@redhat.com> >> --- > > Makes sense. Ran the described environment without this patch (errors) > and again with this patch (graceful exit w/ message). > > Tested-by: Matthew Rosato <mjros...@linux.vnet.ibm.com>
Can someone review http://patchwork.ozlabs.org/patch/760010/ which does at least start to add the SIGP support. Once tcg can bring up 2 cpus, I see no reason it couldn't bring up N. I don't see the point of the define. r~