Philippe Mathieu-Daudé, on ven. 08 sept. 2017 13:19:56 -0300, wrote: > Hi David, > > On 09/08/2017 12:53 PM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > > > > e.g. > > ./x86_64-softmmu/qemu-system-x86_64 -nographic -netdev > > 'user,id=vnet,hostfwd=:555.0.0.0:0-:22' > > qemu-system-x86_64: -netdev user,id=vnet,hostfwd=:555.0.0.0:0-:22: Invalid > > host forwarding rule ':555.0.0.0:0-:22' (Bad host address) > > > > Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > > --- > > net/slirp.c | 13 ++++++++++++- > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > > diff --git a/net/slirp.c b/net/slirp.c > > index 01ed21c006..d87664d42e 100644 > > --- a/net/slirp.c > > +++ b/net/slirp.c > > @@ -496,9 +496,11 @@ static int slirp_hostfwd(SlirpState *s, const char > > *redir_str, > > char buf[256]; > > int is_udp; > > char *end; > > + const char *fail_reason = ""; > > Isn't it better not initialize this? So if one add a new failed syntax case > the build with abort with -Werror=uninitialized > > Anyway: > Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
Applied to my tree, thanks! (I have put Unknown reason there, otherwise the message would have oddly-looking "()" ) Samuel
