On 10/09/2017 16:37, Mark Cave-Ayland wrote: > This change was suggested by Alexey in advance of a subsequent commit which > adds access_type into vmstate_ppc_cpu. > > Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> > --- > target/ppc/cpu.h | 4 ++-- > target/ppc/machine.c | 4 +++- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h > index 12f0949..59d1656 100644 > --- a/target/ppc/cpu.h > +++ b/target/ppc/cpu.h > @@ -1010,8 +1010,8 @@ struct CPUPPCState { > /* Next instruction pointer */ > target_ulong nip; > > - int access_type; /* when a memory exception occurs, the access > - type is stored here */ > + uint8_t access_type; /* when a memory exception occurs, the access > + type is stored here */
I think this breaks TCG as we have: target/ppc/translate.c: 82 void ppc_translate_init(void) ... 191 192 cpu_access_type = tcg_global_mem_new_i32(cpu_env, 193 offsetof(CPUPPCState, access_type), "access_type"); 194 195 done_init = 1; 196 } it expects an int32_t (or int). Thanks, Laurent