On 11 September 2017 at 19:13, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > On 09/10/2017 11:28 PM, Philippe Mathieu-Daudé wrote: >> >> changed in 659ef5cbb893, this fixes building with >> --enable-tcg-interpreter: >> >> /home/travis/build/qemu/qemu/tcg/tcg.c:116:14: error: >> ‘tcg_out_ldst_finalize’ used but never defined [-Werror] >> static bool tcg_out_ldst_finalize(TCGContext *s); >> ^ >> >> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > > > I'm not sure I can sign for Jincheng, but since his patch has the same > content you could add: > > Signed-off-by: Jincheng Miao <jincheng.m...@gmail.com>
In that sort of case we generally just say "first person's patch won". Extra signed-off-by tags are for where there's really multiple peoples' work in the patch. thanks -- PMM
