On 09/12/2017 02:29 AM, Thomas Huth wrote: > On 11.09.2017 19:19, Eric Blake wrote: >> Commit 2f8b2767 originally added qpci_plug_device_test() and >> qpci_unplug_acpi_device_test() as a pair, both in pci-pc.c. >> Later, commit cf716b31 moved one half of the pair to pci.c >> when adding PPC64 support. Keep the implementations of the >> two functions together, and shorten the name to >> qpci_unplug_device_test(), since all callers use the two >> functions in tandem. >>
> > No, that's a bad idea. ACPI and that outb() is clearly something > specific to x86, so this should not reside in pci.c but in pci-pc.c > > We might be able to unify this - I've had a similar patch here: > > https://patchwork.kernel.org/patch/9905031/ > > ... but I think this needs some more careful thinking and discussion, so > I'd suggest that you remove this from your already huge patch series for > now and we fix it later instead. Okay, I'm fine dropping this patch, and can base my respin on top of your cleanup instead. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
