On Tue, 12 Sep 2017 16:01:47 +0200 Laurent Vivier <lviv...@redhat.com> wrote:
> Running QEMU with
> qemu-system-ppc64 -M none -nographic -m 256
> and executing
> dump-guest-memory /dev/null 0 8192
> results in segfault
>
> Fix by checking if we have CPU, and exit with
> error if there is no CPU:
>
> (qemu) dump-guest-memory /dev/null
> this feature or command is not currently supported
>
> Signed-off-by: Laurent Vivier <lviv...@redhat.com>
> ---
Reviewed-by: Greg Kurz <gr...@kaod.org>
> target/ppc/arch_dump.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/target/ppc/arch_dump.c b/target/ppc/arch_dump.c
> index 8e9397aa58..95b9ab6f29 100644
> --- a/target/ppc/arch_dump.c
> +++ b/target/ppc/arch_dump.c
> @@ -224,8 +224,15 @@ typedef struct NoteFuncDescStruct NoteFuncDesc;
> int cpu_get_dump_info(ArchDumpInfo *info,
> const struct GuestPhysBlockList *guest_phys_blocks)
> {
> - PowerPCCPU *cpu = POWERPC_CPU(first_cpu);
> - PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(cpu);
> + PowerPCCPU *cpu;
> + PowerPCCPUClass *pcc;
> +
> + if (first_cpu == NULL) {
> + return -1;
> + }
> +
> + cpu = POWERPC_CPU(first_cpu);
> + pcc = POWERPC_CPU_GET_CLASS(cpu);
>
> info->d_machine = PPC_ELF_MACHINE;
> info->d_class = ELFCLASS;
pgpK6BJKgeYTW.pgp
Description: OpenPGP digital signature
