On Thu, Sep 14, 2017 at 09:26:49PM -0700, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [Qemu-devel] [PULL 00/18] ppc-for-2.11 queue 20170915 > Message-id: 20170915035130.8354-1-da...@gibson.dropbear.id.au > Type: series > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > git config --local diff.renamelimit 0 > git config --local diff.renames True > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; > then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Switched to a new branch 'test' > 872afb4d17 ppc/kvm: use kvm_vm_check_extension() in kvmppc_is_pr() > 7a25c28fcc spapr_events: use QTAILQ_FOREACH_SAFE() in > spapr_clear_pending_events() > 925177495a spapr_cpu_core: cleaning up qdev_get_machine() calls > e0a96b5c4d spapr_pci: don't create 64-bit MMIO window if we don't need to > 1851b264d5 spapr_pci: convert sprintf() to g_strdup_printf() > e62bfeb753 spapr_cpu_core: fail gracefully with non-pseries machine types > d68c815c09 xics: fix several error leaks > 165724544b vfio, spapr: Fix levels calculation > e0d3f60741 spapr_pci: handle FDT creation errors with _FDT() > 9d82d580aa spapr_pci: use the common _FDT() helper > fe74e07d9f spapr: fix CAS-generated reset > 53b3f63411 ppc/xive: fix OV5_XIVE_EXPLOIT bits > 48ced9b1af spapr: only update SDR1 once per-cpu during CAS > 868444ad8c spapr_pci: use g_strdup_printf() > dbfa7f0124 spapr_pci: drop useless check in spapr_populate_pci_child_dt() > 2d5463163b spapr_pci: drop useless check in spapr_phb_vfio_get_loc_code() > 0d760c3eed hw/ppc/spapr.c: cleaning up qdev_get_machine() calls > 2add13654e net: Add SunGEM device emulation as found on Apple UniNorth > > === OUTPUT BEGIN === > Checking PATCH 1/18: net: Add SunGEM device emulation as found on Apple > UniNorth... > Checking PATCH 2/18: hw/ppc/spapr.c: cleaning up qdev_get_machine() calls... > Checking PATCH 3/18: spapr_pci: drop useless check in > spapr_phb_vfio_get_loc_code()... > Checking PATCH 4/18: spapr_pci: drop useless check in > spapr_populate_pci_child_dt()... > Checking PATCH 5/18: spapr_pci: use g_strdup_printf()... > Checking PATCH 6/18: spapr: only update SDR1 once per-cpu during CAS... > Checking PATCH 7/18: ppc/xive: fix OV5_XIVE_EXPLOIT bits... > Checking PATCH 8/18: spapr: fix CAS-generated reset... > Checking PATCH 9/18: spapr_pci: use the common _FDT() helper... > Checking PATCH 10/18: spapr_pci: handle FDT creation errors with _FDT()... > Checking PATCH 11/18: vfio, spapr: Fix levels calculation... > Checking PATCH 12/18: xics: fix several error leaks... > Checking PATCH 13/18: spapr_cpu_core: fail gracefully with non-pseries > machine types... > Checking PATCH 14/18: spapr_pci: convert sprintf() to g_strdup_printf()... > Checking PATCH 15/18: spapr_pci: don't create 64-bit MMIO window if we don't > need to... > ERROR: spaces required around that '-' (ctx:VxV) > #55: FILE: hw/ppc/spapr_pci.c:1625: > + if (sphb->mem64_win_pciaddr != (hwaddr)-1) { > ^ > > ERROR: spaces required around that '-' (ctx:VxV) > #62: FILE: hw/ppc/spapr_pci.c:1632: > + if (sphb->mem64_win_addr != (hwaddr)-1) { > ^ >
These are false positives, a patch for checkpatch.pl is in the works. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature