[Qemu-devel] Re: [PATCH 07/10] ram_save_remaining() returns an uint64_t

[Paolo Bonzini]

On 11/30/2010 03:06 AM, Anthony Liguori wrote:

-static ram_addr_t ram_save_remaining(void)
+static uint64_t ram_save_remaining(void)
  {
      RAMBlock *block;
-    ram_addr_t count = 0;
+    uint64_t count = 0;

      QLIST_FOREACH(block,&ram_list.blocks, next) {
          ram_addr_t addr;

No, it returns a count of bytes of ram which is a subset of ram_addr_t's
space.  The unit is definitely right here.

It returns a count of pages, actually, which is a different unit.  For 
example, in practice it can fit in 32 bits even (though I'm not saying 
we should make it uint32_t; we'd be dangerously close to the limit for 
the guest sizes that Juan is handling).

Paolo