Hi, This series seems to have some coding style problems. See output below for more information:
Subject: [Qemu-devel] [PATCH v3 0/6] QOMify MIPS cpu Message-id: 20170917232010.14183-1-f4...@amsat.org Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' e822fe0c5d mips: replace cpu_mips_init() with cpu_generic_init() 496f38ac4a mips: MIPSCPU model subclasses e8855206ec mips: call cpu_mips_realize_env() from mips_cpu_realizefn() e9ec165d39 mips: split cpu_mips_realize_env() out of cpu_mips_init() 2923193832 mips: introduce internal.h and cleanup cpu.h 146f4059ea mips: move hw/mips/cputimer.c to target/mips/ === OUTPUT BEGIN === Checking PATCH 1/6: mips: move hw/mips/cputimer.c to target/mips/... Checking PATCH 2/6: mips: introduce internal.h and cleanup cpu.h... ERROR: space prohibited after that '&' (ctx:WxW) #728: FILE: target/mips/internal.h:230: + if ((env->CP0_VPControl >> CP0VPCtl_DIS) & 1) { ^ ERROR: space prohibited after that '&' (ctx:WxW) #736: FILE: target/mips/internal.h:238: + ((other_cpu->env.CP0_VPControl >> CP0VPCtl_DIS) & 1)) { ^ ERROR: space prohibited after that '&' (ctx:WxW) #756: FILE: target/mips/internal.h:258: + env->hflags |= (env->CP0_Status >> CP0St_KSU) & MIPS_HFLAG_KSU; ^ total: 3 errors, 0 warnings, 842 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/6: mips: split cpu_mips_realize_env() out of cpu_mips_init()... Checking PATCH 4/6: mips: call cpu_mips_realize_env() from mips_cpu_realizefn()... Checking PATCH 5/6: mips: MIPSCPU model subclasses... Checking PATCH 6/6: mips: replace cpu_mips_init() with cpu_generic_init()... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org