Hi Sundeep,

On 09/14/2017 01:36 AM, Philippe Mathieu-Daudé wrote:
On 09/07/2017 04:24 PM, Subbaraya Sundeep wrote:
[...]
+static inline int msf2_divbits(uint32_t div)

Please directly use ctz32() instead of msf2_divbits()

It seems you missed this review comment in your v9.


+{
+    int ret = 0;
+
+    switch (div) {
+    case 1:
+        ret = 0;
+        break;
+    case 2:
+        ret = 1;
+        break;
+    case 4:
+        ret = 2;
+        break;
+    case 8:
+        ret = 4;
+        break;
+    case 16:
+        ret = 5;
+        break;
+    case 32:
+        ret = 6;
+        break;
+    default:
+        break;
+    }
+
+    return ret;
+}

Reply via email to