On 01.12.2010, at 14:17, Kevin Wolf wrote: > Am 01.12.2010 14:09, schrieb Stefan Hajnoczi: >> On Fri, Nov 26, 2010 at 7:17 PM, Alexander Graf <ag...@suse.de> wrote: >> Just some cosmetic suggestions. >> >>> @@ -2716,6 +2736,12 @@ static void ide_init1(IDEBus *bus, int unit) >>> ide_sector_write_timer_cb, s); >>> } >>> >>> +static IDEBusOps ide_bus_ops = { >> >> Since the functions are all pata_* I think it makes sense for this to >> be called pata_bus_ops, not ide_bus_ops. >> >>> + .transfer_start_fn = pata_transfer_start, >>> + .irq_set_fn = pata_set_irq, >> >> irq_set or set_irq? :) Let's consistently go with set_irq. > > And drop the _fn suffix? It's really obvious that these are functions > (if this is what it's meant to say).
Good points :) Alex