On 22 September 2017 at 16:39, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > while here, remove unused #include from aspeed_smc.h > > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > hw/input/adb.c | 2 +- > hw/ssi/aspeed_smc.c | 3 +-- > numa.c | 1 - > 3 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/hw/input/adb.c b/hw/input/adb.c > index fcca3a8eb9..924a3f9fd5 100644 > --- a/hw/input/adb.c > +++ b/hw/input/adb.c > @@ -24,8 +24,8 @@ > #include "qemu/osdep.h" > #include "hw/hw.h" > #include "hw/input/adb.h" > +#include "hw/input/adb-keys.h" > #include "ui/console.h" > -#include "include/hw/input/adb-keys.h" > #include "ui/input.h" > #include "sysemu/sysemu.h" > > diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c > index cb515730c5..5059396bc6 100644 > --- a/hw/ssi/aspeed_smc.c > +++ b/hw/ssi/aspeed_smc.c > @@ -26,8 +26,7 @@ > #include "hw/sysbus.h" > #include "sysemu/sysemu.h" > #include "qemu/log.h" > -#include "include/qemu/error-report.h" > -#include "exec/address-spaces.h" > +#include "qemu/error-report.h" > > #include "hw/ssi/aspeed_smc.h" > > diff --git a/numa.c b/numa.c > index 100a67febf..ebc553b5d9 100644 > --- a/numa.c > +++ b/numa.c > @@ -29,7 +29,6 @@ > #include "qemu/bitmap.h" > #include "qom/cpu.h" > #include "qemu/error-report.h" > -#include "include/exec/cpu-common.h" /* for RAM_ADDR_FMT */ > #include "qapi-visit.h" > #include "qapi/opts-visitor.h" > #include "hw/boards.h" > -- > 2.14.1
"while here" usually indicates a patch should be split. Otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM