On Fri, 22 Sep 2017 17:39:35 +0200 Pierre Morel <pmo...@linux.vnet.ibm.com> wrote:
> On 21/09/2017 20:08, Halil Pasic wrote: > > Replace direct access which implicitly assumes no IDA > > or MIDA with the new ccw data stream interface which should > > cope with these transparently in the future. > > > > Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> > > Reviewed-by: Pierre Morel<pmo...@linux.vnet.ibm.com> > > Reviewed-by: Dong Jia Shi <bjsdj...@linux.vnet.ibm.com> > > --- > > hw/s390x/virtio-ccw.c | 155 > > +++++++++++++++----------------------------------- > > 1 file changed, 46 insertions(+), 109 deletions(-) > LGTM. > Not testing the return value for ccw_dstream_read/write_buf() bother me > but I can understand that you will modify this later. > May be a comment? > Not a strong opinion. I can add "Note that checking the return code for ccw_dstream_* will be done in a follow-on patch." > > Reviewed-by: Pierre Morel<pmo...@linux.vnet.ibm.com> > >
