On 10/03/2017 01:43 PM, Jeff Cody wrote: > On Tue, Oct 03, 2017 at 11:59:28AM -0400, John Snow wrote: >> >> >> On 10/03/2017 11:57 AM, Paolo Bonzini wrote: >>> On 03/10/2017 05:15, John Snow wrote: >>>> For drive-backup and blockdev-backup, expose the manual-cull >>>> property, having it default to false. There are no universal >>>> creation parameters, so it must be added to each job type that >>>> it makes sense for individually. >>>> >>>> Signed-off-by: John Snow <js...@redhat.com> >> >> [...] >> >>> >>> The verb "cull" is a bit weird. The only alternative that comes to mind >>> though are "reap" (like processes). There's also "join" (like threads), >>> but would imply waiting if the jobs hasn't completed yet, and we >>> probably don't want it. >>> >>> Paolo >>> >> >> Sure, open to suggestions. I think Kevin suggested "delete" which I have >> reservations about because of people potentially confusing it with >> "cancel" or "complete" -- it does not have the capacity to >> end/terminate/finish/complete/cancel a job. >> >> "reap" might be fine. I don't really have any strong preference. >> > > As far as verbs go, I like both 'reap' and 'delete'. As far as the > property, naming it 'manual_verb' is a bit odd, too. Maybe a clearer term > for the property would just be 'persistent', with the QMP command being > 'block_job_reap' or 'block_job_delete'? > > -Jeff >
As they say, two hard problems in Computer Science ...