Reviewed-by: Ronnie Sahlberg <ronniesahlb...@gmail.com> Would be nice if this died at some stage : [,password=password]
But that is for a different patch. On Wed, Oct 4, 2017 at 8:12 PM, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > On Mon, Oct 2, 2017 at 4:03 PM, Markus Armbruster <arm...@redhat.com> wrote: >> -iscsi ended up under the "Device URL Syntax" heading by a sequence of >> errors, as explained in the previous commit. Move it under the "Block >> device options" heading. Nothing left under "Device URL Syntax"; >> drop the heading. >> >> Cc: Ronnie Sahlberg <ronniesahlb...@gmail.com> >> Cc: Kevin Wolf <kw...@redhat.com> >> Cc: Max Reitz <mre...@redhat.com> >> Cc: qemu-bl...@nongnu.org >> Signed-off-by: Markus Armbruster <arm...@redhat.com> > > Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> > > >> --- >> qemu-options.hx | 15 +++++++-------- >> 1 file changed, 7 insertions(+), 8 deletions(-) >> >> diff --git a/qemu-options.hx b/qemu-options.hx >> index f112281d37..c647fdde62 100644 >> --- a/qemu-options.hx >> +++ b/qemu-options.hx >> @@ -1172,6 +1172,13 @@ STEXI >> Create synthetic file system image >> ETEXI >> >> +DEF("iscsi", HAS_ARG, QEMU_OPTION_iscsi, >> + "-iscsi [user=user][,password=password]\n" >> + " [,header-digest=CRC32C|CR32C-NONE|NONE-CRC32C|NONE\n" >> + " [,initiator-name=initiator-iqn][,id=target-iqn]\n" >> + " [,timeout=timeout]\n" >> + " iSCSI session parameters\n", QEMU_ARCH_ALL) >> + >> STEXI >> @end table >> ETEXI >> @@ -2811,14 +2818,6 @@ STEXI >> ETEXI >> DEFHEADING() >> >> -DEFHEADING(Device URL Syntax:) >> -DEF("iscsi", HAS_ARG, QEMU_OPTION_iscsi, >> - "-iscsi [user=user][,password=password]\n" >> - " [,header-digest=CRC32C|CR32C-NONE|NONE-CRC32C|NONE\n" >> - " [,initiator-name=initiator-iqn][,id=target-iqn]\n" >> - " [,timeout=timeout]\n" >> - " iSCSI session parameters\n", QEMU_ARCH_ALL) >> - >> DEFHEADING(Bluetooth(R) options:) >> STEXI >> @table @option >> -- >> 2.13.6 >> >> > > > > -- > Marc-André Lureau