On Wed, Oct 04, 2017 at 12:59:04PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 04.10.2017 01:00, Alex Williamson wrote: > > Commit c3e5875afc0f ("checkpatch: check trace-events code style") > > introduces a regression as reported: > > > > https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg05820.html > > > > Bareword found where operator expected at ./scripts/checkpatch.pl line > > 1350, near "s/($hex[.:\/ ])+$hex//gr" > > syntax error at ./scripts/checkpatch.pl line 1350, near "s/($hex[.:\/ > > ])+$hex//gr" > > Execution of ./scripts/checkpatch.pl aborted due to compilation errors. > > > > $ perl -v > > > > This is perl, v5.10.1 (*) built for x86_64-linux-thread-multi > > v5.10.1 is 8 years old. > most possibly the error relates to /r modifier, which was added int perl > 5.14, so, possible solution would be > > @@ -1432,7 +1432,8 @@ sub process { > qr/%[-+ > *.0-9]*([hljztL]|ll|hh)?(x|X|"\s*PRI[xX][^"]*"?)/; > > # don't consider groups splitted by [.:/ ], like 2A.20:12ab > - my $tmpline = $rawline =~ s/($hex[.:\/ ])+$hex//gr; > + my $tmpline = $rawline; > + my $tmpline =~ s/($hex[.:\/ ])+$hex//g; > > if ($tmpline =~ /(?<!0x)$hex/) { > ERROR("Hex numbers must be prefixed with '0x'\n" .
Yes, that fixes the error when run on a rhel6 vintage Perl. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|