On 04.10.2017 14:46, Juan Quintela wrote: > Thomas Huth <th...@redhat.com> wrote: >> On 04.10.2017 12:39, Juan Quintela wrote: >>> Signed-off-by: Juan Quintela <quint...@redhat.com> > >> >> Looks like a lot of this code is the same or very similar to the code in >> postcopy-test.c ... would it make sense to factor-out that code there >> into a separate file that could be used by both tests, so that we do not >> have to maintain the code twice? > > > I think I put that on the cover letter, my idea is to add the postcopy > test here. OK, then I think you should remove the duplicated functions from postcopy-test.c in the same patch here, so that it is more obvious that this is a code movement.
Thomas PS: Please also add an entry to MAINTAINERS for the new files if feasible.
