On Wed, Oct 04, 2017 at 06:44:20PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Do not use '/r' modifier which was introduced in perl 5.14. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > --- > scripts/checkpatch.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrange <berra...@redhat.com> > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 3c0a28e644..0c41f1212f 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -1432,7 +1432,8 @@ sub process { > qr/%[-+ > *.0-9]*([hljztL]|ll|hh)?(x|X|"\s*PRI[xX][^"]*"?)/; > > # don't consider groups splitted by [.:/ ], > like 2A.20:12ab > - my $tmpline = $rawline =~ s/($hex[.:\/ > ])+$hex//gr; > + my $tmpline = $rawline; > + $tmpline =~ s/($hex[.:\/ ])+$hex//g; > > if ($tmpline =~ /(?<!0x)$hex/) { > ERROR("Hex numbers must be prefixed > with '0x'\n" . Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|