On Wed, 4 Oct 2017 17:41:44 +0200 Halil Pasic <pa...@linux.vnet.ibm.com> wrote:
> Some of ioinst the handlers look very much the same: they basically > delegate the work to the appropriate css function (doing some always the > same stuff before and after the call to the appropriate css function). > Let us create a template and get rid of some code. > > Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> > Suggested-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> > --- > target/s390x/ioinst.c | 59 > ++++++++++++--------------------------------------- > 1 file changed, 14 insertions(+), 45 deletions(-) Staring at this patch, I'm not sure I like it, although I can't quite put a finger on *what* I don't like... maybe the whole 'template' approach.
