Le 16/10/2017 à 15:06, Riku Voipio a écrit : > On Thu, Oct 12, 2017 at 07:08:55PM +0200, Laurent Vivier wrote: >> Le 12/10/2017 à 18:53, Peter Maydell a écrit : >>> On 12 October 2017 at 17:49, Laurent Vivier <laur...@vivier.eu> wrote: >>>> Le 12/10/2017 à 17:30, Peter Maydell a écrit : >>>>> +#if defined(TARGET_SPARC) || defined(TARGET_MIPS) >>>>> +typedef abi_long target_kernel_daddr_t; >>>>> +#else >>>>> +typedef abi_int target_kernel_daddr_t; >>>>> +#endif >>>> >>>> Perhaps you can add these ones into include/exec/user/abitypes.h ? >>> >>> I don't think they belong there -- that file is for basic >>> CPU ABI dependent types, not things which are just part of >>> the kernel interface. > >> I agree > > So we should go with the patch as-is?
For this part, yes, but I think for the other comment, STRUCT(mtget, ...) needs to be updated. Thanks, Laurent
