On 17.10.2017 12:49, Philippe Mathieu-Daudé wrote: > Hi Thomas, > >>> diff --git a/hw/display/vga_int.h b/hw/display/vga_int.h >>> index ad34a1f048..fe23b81442 100644 >>> --- a/hw/display/vga_int.h >>> +++ b/hw/display/vga_int.h >>> @@ -25,8 +25,9 @@ >>> #ifndef HW_VGA_INT_H >>> #define HW_VGA_INT_H >>> >>> -#include "hw/hw.h" >>> +#include "exec/ioport.h" >>> #include "exec/memory.h" >>> +#include "ui/console.h" >> >> So vga_int.h now includes console.h (is it really necessary?) ... > > The VGACommonState struct has a GraphicHwOps *hw_ops member.
Ok, thanks, I just wanted to confirm that this is needed here. [...] > Do you suggest me do declare GraphicHwOps opaque in "qemu/typedefs.h"? No, I think it's fine if you keep the #include in vga_int.h, I just wanted to make sure that it is really needed there. So please just remove the #includes from the .c files instead. Thomas
