"Dr. David Alan Gilbert" <dgilb...@redhat.com> wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Signed-off-by: Juan Quintela <quint...@redhat.com> >> --- >> tests/migration-test.c | 71 >> ++++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 71 insertions(+) >> >> diff --git a/tests/migration-test.c b/tests/migration-test.c >> index 8ef2b72459..8549e4c2c6 100644 >> --- a/tests/migration-test.c >> +++ b/tests/migration-test.c >> @@ -422,6 +422,76 @@ static void migrate_set_parameter(QTestState *who, >> const char *parameter, >> QDECREF(rsp); >> } >> >> +static void migrate_set_downtime(QTestState *who, const char *value) >> +{ >> + QDict *rsp; >> + gchar *cmd; >> + >> + cmd = g_strdup_printf("{ 'execute': 'migrate_set_downtime'," >> + "'arguments': { 'value': %s } }", value); >> + rsp = qtest_qmp(who, cmd); >> + g_free(cmd); >> + g_assert(qdict_haskey(rsp, "return")); >> + QDECREF(rsp); >> +} >> + >> +static void migrate_set_speed(QTestState *who, const char *value) >> +{ >> + QDict *rsp; >> + gchar *cmd; >> + >> + cmd = g_strdup_printf("{ 'execute': 'migrate_set_speed'," >> + "'arguments': { 'value': %s } }", value); >> + rsp = qtest_qmp(who, cmd); >> + g_free(cmd); >> + g_assert(qdict_haskey(rsp, "return")); >> + QDECREF(rsp); >> +} >> + >> +static void test_precopy_deprecated(const char *uri) >> +{ >> + QTestState *from, *to; >> + >> + test_migrate_start(&from, &to, uri); >> + >> + /* We want to pick a speed slow enough that the test completes >> + * quickly, but that it doesn't complete precopy even on a slow >> + * machine, so also set the downtime. >> + */ >> + /* 100 ms */ >> + migrate_set_downtime(from, "100"); >> + /* 1MB/s slow*/ >> + migrate_set_speed(from, "100000000"); > > Can't we share more/most of this function? > For example, how about we have a migrate_set_speed(who,value, old) > tht is : > if (old) { > migrate_set_speed... > } else { > migrate_set_parameter > } > > then test_precopy(const char *uri, bool old) > > and we've duped most of it?
Moved to different setup, we end having: - migrate_set_parameter and - migrate_set_speed - migrate_set_downtime - migrate_set_cache_size My plan would be to test that if you don't use deprecated interfaces, you don't need to deal with them. Later, Juan.