On 10/18/2017 11:19 AM, Emilio G. Cota wrote: > On Wed, Oct 18, 2017 at 09:41:43 +0200, Paolo Bonzini wrote: >> On 16/10/2017 19:25, Richard Henderson wrote: >>> * Translation Cache-related fields of a TB. >>> + * This struct exists just for convenience; we keep track of TB's in a >>> binary >>> + * search tree, and the only fields needed to compare TB's in the tree are >>> + * @ptr and @size. @search is brought here for consistency, since it is >>> also >>> + * a TC-related field. >>> */ >>> struct tb_tc { >>> void *ptr; /* pointer to the translated code */ >>> uint8_t *search; /* pointer to search data */ >>> + size_t size; >>> }; >> >> Isn't search equal to ptr + size, or something like that? > > It is indeed! Fixup below. > > The change shrinks TranslationBlock, but it leaves performance unchanged > (recall that we add padding after TranslationBlock to avoid cache line > overlap between the struct and translated code). > > Thanks, > > Emilio > > -- >8 -- > Subject: [PATCH] fixup
Merged, thanks. r~