On Fri, Oct 20, 2017 at 03:46:54PM +0200, Bastian Koppelmann wrote: > I asked you for feedback some while ago regarding a modular RISC-V QEMU > target (see discussion [1]). I tried getting it to work with the good > old C preprocessor and quickly realized that it is too limiting. Instead > I created a data-driven decoder generator written in python (see the > code on github [2]) using YAML as a description language. > > I'd like to get some feedback whether this is acceptable to be > upstreamed to QEMU or if you have any suggestions for improvements. > Right now only RV32I instruction are implemented in this scheme.
My suggestion would be to reimplement (part of) the s390x decoder using this scheme. That would give us a direct comparison of how your scheme is better or worse than the existing macros. Will you be at the KVM Forum next week? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org
