On Mon, Oct 23, 2017 at 10:02:20AM +0200, Alistair Francis wrote: > On Wed, Oct 18, 2017 at 10:35 AM, Daniel P. Berrange > <berra...@redhat.com> wrote: > > On Wed, Oct 18, 2017 at 04:28:36PM +0800, Fam Zheng wrote: > >> On Wed, 10/18 01:08, no-re...@patchew.org wrote: > >> > Your branch is up-to-date with 'origin/test'. > >> > Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path > >> > 'dtc' > >> > Cloning into > >> > '/var/tmp/patchew-tester-tmp-jhpnlaz0/src/docker-src.2017-10-18-04.03.32.32287/qemu.tar.vroot/dtc'... > >> > fatal: unable to connect to git.qemu-project.org: > >> > git.qemu-project.org[0: 172.99.69.163]: errno=Connection timed out > >> > > >> > fatal: clone of 'git://git.qemu-project.org/dtc.git' into submodule path > >> > '/var/tmp/patchew-tester-tmp-jhpnlaz0/src/docker-src.2017-10-18-04.03.32.32287/qemu.tar.vroot/dtc' > >> > failed > >> > Failed to clone 'dtc'. Retry scheduled > >> > Cloning into > >> > '/var/tmp/patchew-tester-tmp-jhpnlaz0/src/docker-src.2017-10-18-04.03.32.32287/qemu.tar.vroot/dtc'... > >> > fatal: unable to connect to git.qemu-project.org: > >> > git.qemu-project.org[0: 172.99.69.163]: errno=Connection timed out > >> > > >> > fatal: clone of 'git://git.qemu-project.org/dtc.git' into submodule path > >> > '/var/tmp/patchew-tester-tmp-jhpnlaz0/src/docker-src.2017-10-18-04.03.32.32287/qemu.tar.vroot/dtc' > >> > failed > >> > Failed to clone 'dtc' a second time, aborting > >> > failed to init submodule dtc > >> > >> So now patchew is less robust on network hiccups: a number of the same "git > >> submodule update --init" calls have succeeded above, so this is > >> incidental. Any > >> idea how to improve that? Maybe if there is a checkout from $QEMU_SRC, > >> clone/cp > >> from there instead of fetch from submodule remote? > > > > If patchew has unreliable connectivity to git.qemu.org then the best thing > > is probably have a background job that mirrors the git.qemu.org repos on > > the patchew server. Then have the test job modify .gitmodules to point to > > your local mirror. That way, network access is used during the background > > job only, and actual builds just get a local clone from the cache. > > It looks like git://git.qemu-project.org/dtc.git is completely down > now, so I'm not sure it's only a patchew issue. > > I think having a fall back to the locally checked out submodule would > be a good idea, QEMU submodules don't update that often. > > Whatever the solution ends up being can we have something in tree that > others can use? We run the Docker tests internally and I would like to > have the same setup (plus it saves me having to maintain something :) > ).
What is already in tree works just fine for developers in general. You can just run 'make docker-BLAH' and it'll right the right thing. If devs hit a transient problem with git they can just re-run it. The problem here is just about ensuring that patchew has as close to 100% reliable checkout as possible, by minimizing the impact of transient network failures for it. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|