On 14 October 2017 at 19:38, Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> wrote: > This enables them to be used outside of lance.c. > > Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> > CC: Jason Wang <jasow...@redhat.com> > --- > hw/net/lance.c | 9 --------- > include/hw/sparc/sun4m.h | 13 +++++++++++++ > 2 files changed, 13 insertions(+), 9 deletions(-)
I would suggest creating a new header file for this device, include/hw/net/lance.h, rather than stuffing it into the sun4m.h header. (That kind of header is a bit of a legacy from when we had ad-hoc header organization, so in general we'd expect things to go out of it rather than be added to it...) thanks -- PMM
